Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries to SDK download in VerifyDotnetFolderContents test #6281

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

lbussell
Copy link
Contributor

@lbussell lbussell commented Feb 26, 2025

The VerifyDotnetFolderContents test is causing flaky PR validation due to issues with downloading the SDK from the internet. This PR adds retry logic to the test.

Other changes:

  • Pulled HttpClient and auth stuff out as static members
  • Enabled nullable annotations in the file
  • Cleaned up what I saw as unnecessary code
    • IEqualityComparer
    • use record value equality instead of IComparable

@lbussell lbussell requested a review from a team as a code owner February 26, 2025 19:27
@lbussell lbussell merged commit de3a873 into dotnet:nightly Feb 26, 2025
120 checks passed
lbussell added a commit to lbussell/dotnet-docker that referenced this pull request Mar 6, 2025
lbussell added a commit to lbussell/dotnet-docker that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants